Skip to content

docs: update nodejs versions to 22 in README.md #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mertssmnoglu
Copy link
Contributor

@mertssmnoglu mertssmnoglu commented May 30, 2025

Description

Updated node:8 and node:16 image tags to node:22 in README. Update docker-compose example.

Motivation and Context

As a developer, I would like to see latest LTS version in the documentation.

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@mertssmnoglu
Copy link
Contributor Author

mertssmnoglu commented May 30, 2025

I'm also thinking about updating docker compose example too. Is it OK to do it in this PR?

services:
  node:
    image: "node:22"
    environment:
      - NODE_ENV=production
    volumes:
      - ./:/home/node/app
    ports: # use if it is necessary to expose the container to the host machine
      - "8081:8081"
    command: ["npm", "start"]

@SimenB
Copy link
Member

SimenB commented Jul 16, 2025

I'm also thinking about updating docker compose example too. Is it OK to do it in this PR?

services:
  node:
    image: "node:22"
    environment:
      - NODE_ENV=production
    volumes:
      - ./:/home/node/app
    ports: # use if it is necessary to expose the container to the host machine
      - "8081:8081"
    command: ["npm", "start"]

Yes please 🙂

@mertssmnoglu mertssmnoglu marked this pull request as ready for review July 24, 2025 10:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Node.js version references in documentation from older versions (8 and 16) to the latest LTS version 22, ensuring developers have current examples for Docker usage.

  • Updated Node.js Docker image tags from node:8 and node:16 to node:22
  • Modernized docker-compose configuration by removing deprecated version field and updating syntax
  • Updated port mappings and command format in docker-compose example

image: "node:8"
user: "node"
working_dir: /home/node/app
image: "node:22"
Copy link
Preview

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docker-compose example removes important configuration like user: "node" and working_dir: /home/node/app without explanation. These settings are security and functionality best practices that should be retained or their removal should be justified.

Suggested change
image: "node:22"
image: "node:22"
user: "node"
working_dir: /home/node/app

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really?

@PeterDaveHello
Copy link
Member

@coderabbitai, could you provide a better PR subject and description?

@PeterDaveHello
Copy link
Member

Summary from GitHub Copilot:

This pull request updates the Node.js version used in the Docker configurations and examples within the README.md file. The changes ensure consistency across the documentation and upgrade the Node.js version to 22.

Updates to Node.js version in Docker configurations:

  • Updated the Node.js base image in the Dockerfile example from node:16 to node:22. (README.md, README.mdL55-R55)
  • Modified the Docker Compose example to use node:22 as the image, updated the exposed port to 8888, and adjusted the command syntax to use an array format. (README.md, README.mdL70-R79)
  • Updated the standalone Docker command example to use node:22 instead of node:8. (README.md, README.mdL108-R103)

Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include any related changes in the PR title and description, not just the Node.js version. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants