-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
test: apply a delay to watch-mode-kill-sginal tests #60610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The test is still flaking on macOS. This might be caused by fs event coalescing. Apply a delay to reduce the chance of it. Also, add a bit more logs to show more information.
|
I wonder if this might be a caveat of |
| if (match) { | ||
| firstGrandchildPid = match[1]; // This is the first grandchild | ||
| writeFileSync(indexPath, indexContents); | ||
| const writeDelay = 1000; // Delay to reduce the chance of fs events coalescing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not 100% sure that this would eliminate the effect of coalescing for this test - another option is to, er, write a few more times and cross fingers that they get picked by the fsevent-based watcher? But multiple writes could again lead to the tricky loop we wanted to avoid in #60443. So for now I guess we can just try the timeout and hopefully that is good enough..
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60610 +/- ##
========================================
Coverage 88.55% 88.56%
========================================
Files 704 704
Lines 207981 208099 +118
Branches 40068 40090 +22
========================================
+ Hits 184187 184311 +124
- Misses 15812 15824 +12
+ Partials 7982 7964 -18 🚀 New features to boost your workflow:
|
The test is still flaking on macOS. This might be caused by fs event coalescing. Apply a delay to reduce the chance of it. Also, add a bit more logs to show more information.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-11-07.md