Skip to content

Conversation

@joyeecheung
Copy link
Member

The test is still flaking on macOS. This might be caused by fs event coalescing. Apply a delay to reduce the chance of it. Also, add a bit more logs to show more information.

Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-11-07.md

The test is still flaking on macOS. This might be caused by fs
event coalescing. Apply a delay to reduce the chance of it.
Also, add a bit more logs to show more information.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2025
@joyeecheung
Copy link
Member Author

I wonder if this might be a caveat of --watch in general, which seems to be using fs.watch and therefore risks the caveat of fsevents on macOS...not sure if it's ever considered to support something like --watch-poll for precision.

if (match) {
firstGrandchildPid = match[1]; // This is the first grandchild
writeFileSync(indexPath, indexContents);
const writeDelay = 1000; // Delay to reduce the chance of fs events coalescing
Copy link
Member Author

@joyeecheung joyeecheung Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure that this would eliminate the effect of coalescing for this test - another option is to, er, write a few more times and cross fingers that they get picked by the fsevent-based watcher? But multiple writes could again lead to the tricky loop we wanted to avoid in #60443. So for now I guess we can just try the timeout and hopefully that is good enough..

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (be3fc1f) to head (d0bba5a).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #60610    +/-   ##
========================================
  Coverage   88.55%   88.56%            
========================================
  Files         704      704            
  Lines      207981   208099   +118     
  Branches    40068    40090    +22     
========================================
+ Hits       184187   184311   +124     
- Misses      15812    15824    +12     
+ Partials     7982     7964    -18     

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants