Skip to content

chore: add x86 for Node.js <10 for Linux #8014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jul 23, 2025

This PR adds x86 Platform/Bitness for Linux on Node.js <10

@Copilot Copilot AI review requested due to automatic review settings July 23, 2025 15:01
@ovflowd ovflowd requested a review from a team as a code owner July 23, 2025 15:01
Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 23, 2025 3:02pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for x86 architecture downloads on Linux for older Node.js versions (< 10.0.0). This addresses a gap in platform support for legacy Node.js installations that still require 32-bit architecture compatibility.

  • Adds x86 platform configuration with version-specific compatibility constraints
  • Maintains existing x64 platform support without modifications

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.96%. Comparing base (8cec766) to head (02ebab4).
⚠️ Report is 10 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8014      +/-   ##
==========================================
- Coverage   72.99%   72.96%   -0.03%     
==========================================
  Files          95       95              
  Lines        8317     8324       +7     
  Branches      214      215       +1     
==========================================
+ Hits         6071     6074       +3     
- Misses       2245     2249       +4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 23, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 23, 2025
Copy link
Contributor

github-actions bot commented Jul 23, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 96 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@avivkeller avivkeller added this pull request to the merge queue Jul 25, 2025
Merged via the queue into main with commit f76285a Jul 25, 2025
14 checks passed
@avivkeller avivkeller deleted the chore/add-linux-for-<10 branch July 25, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants