chore: use u256 from bignum #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
reviewed
Dec 19, 2025
TomAFrench
reviewed
Dec 19, 2025
ethereum/circuits/lib/src/uint256.nr
Outdated
Comment on lines
22
to
28
| pub fn from_field(field: Field) -> u256 { | ||
| let bytes = field.to_be_bytes::<32>(); | ||
| let mut bytes33 = [0; 33]; | ||
| for i in 0..32 { | ||
| bytes33[i + 1] = bytes[i]; | ||
| } | ||
| u256::from_be_bytes(bytes33) |
Member
There was a problem hiding this comment.
bignum should expose a method like this already afaik.
TomAFrench
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use u256 from Bignum and remove customized u256 implementation.
Added overflow checks for addition manually.
Problem*
closes #2
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.