chore: add compatibilty for node 24 in acvm_js test suite#10706
chore: add compatibilty for node 24 in acvm_js test suite#10706TomAFrench merged 4 commits intomasterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 73db28f | Previous: fdfb7df | Ratio |
|---|---|---|---|
rollup-checkpoint-merge |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 73db28f | Previous: fdfb7df | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
TomAFrench
force-pushed
the
tf/bump-node
branch
from
2611b41 to
9a84056
Compare
TomAFrench
changed the title
TomAFrench
force-pushed
the
tf/bump-node
branch
from
9a84056 to
6e15b46
Compare
github-actions
bot
added
the
documentation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ACVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 6e15b46 | Previous: c3261da | Ratio |
|---|---|---|---|
perfectly_parallel_batch_inversion_opcodes |
2793760 ns/iter (± 2757) |
2253375 ns/iter (± 8611) |
1.24 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
🚀 Deployed on https://6957cd2887f16e616905932f--noir-docs.netlify.app |
Node 24 requires import attributes for JSON imports which isn't compatible with older Node versions. Using fs.readFileSync with ESM-compatible path resolution works across Node 22+.
|
FYI @noir-lang/developerrelations on Noir doc changes. |
1 participant
Description
Problem
Resolves
Summary
Additional Context
User Documentation
Check one:
PR Checklist
cargo fmton default settings.