Open
Conversation
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
4 times, most recently
from
5f21ed4 to
5989901
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
from
5989901 to
ca0f6ad
Compare
nisar123456
requested review from
bhabanisp123,
ramsai0206,
sayalinaval,
sbagalur and
tbachman
Closed
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
2 times, most recently
from
1043918 to
d324087
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
2 times, most recently
from
b53604c to
455b6e3
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
11 times, most recently
from
14524e0 to
3f8a168
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
from
3f8a168 to
3631f0e
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
2 times, most recently
from
936f2eb to
96cce50
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
6 times, most recently
from
69da5e8 to
3d2c7c2
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
3 times, most recently
from
842f8ff to
6eb4ca1
Compare
tbachman
requested changes
Dec 3, 2025
Contributor
tbachman
left a comment
tbachman
left a comment
There was a problem hiding this comment.
I didn't look through the entire patch - there are a lot of cases where code that was previously safe under concurrency would no longer be protected. I'd like to get a better understanding of why the concurrency there was removed before going further in this patch.
| context, resource, overwrite=True, | ||
| fix_ownership=monitored) | ||
| # Declare victory for the created object | ||
| if isinstance(resource, aim_resource.AciRoot): |
Contributor
There was a problem hiding this comment.
Same concern here - the update is no longer atomic. What was the reason to remove the transaction?
| existing = self.manager.get(context, resource) | ||
| if existing and existing.monitored: | ||
| self.manager.delete(context, resource) | ||
| existing = self.manager.get(context, resource) |
Contributor
There was a problem hiding this comment.
And here - the get/delete code could be concurrent, and therefore needs the protection of a transaction.
aim/aim_lib/nat_strategy.py
Outdated
| phys_domains=phys_domains, | ||
| epg_name=epg_name) | ||
| return l3out_db | ||
| tenant = resource.Tenant(name=l3out.tenant_name) |
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
2 times, most recently
from
817357a to
7678ba1
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
2 times, most recently
from
11686c0 to
4c37ddd
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
2 times, most recently
from
67ff3c5 to
86bed04
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
from
86bed04 to
1b22526
Compare
nisar123456
force-pushed
the
Rebase_SqlAlchemy_2
branch
from
1b22526 to
0a03c73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.