refactor: issue-7818 removed UrlHelperExtensions and its implementations #7821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KaranChadha10 @RomanovM |
|
Hi @KaranChadha10! I'm very sorry, but we didn't have time to review your implementation on time, and it's currently full of conflicts. We've decided to close your PR. We will implement it ourselves, especially since we have decided not to remove the extension methods for now. I hope you understand, and thank you very much for your assistance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed UrlHelperExtensions and switch views/controllers to INopUrlHelper (Fixes #7818)
Issue link: #7818