Reimplement the salvageable UI/UX from #679 and #686#794
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_0dd79907-42fa-4ac1-ac7d-719a6462071d) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1d663b897
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!string.Equals(GetRequestCanonicalPath(context), "/", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| return string.Empty; |
There was a problem hiding this comment.
Preserve a heading when suppressing the scoreboard
When the same index.html shell is served for /athlete/..., /league/..., and /flag/... (checked Invoke, which maps those routes to index.html), this branch returns an empty string for the only new h1 source. Because the commit also removed the old hidden <h1> from index.html and leaderboard-content.html does not provide one, those non-home index routes now render with no primary heading, which regresses accessibility/SEO for athlete and league pages. Consider leaving a fallback h1 when the homepage scoreboard is omitted.
Useful? React with 👍 / 👎.
.NET test coverage
|
Important
Deep reimplementation in progress. This draft is not ready for review or merge.
The earlier homepage-only pass and its validation claims are obsolete. This PR is being expanded into a product-by-product reimplementation of the salvageable intent from #679 and #686 on current
master. Final test counts and screenshots will be added only after the branch is frozen and the exact final build passes every gate below.Reimplementation contract
masteras the behavioral baseline and preserve canonical routes, payloads, rankings, competition rules, storage safety, asset versioning, and responsive flow behavior.DESIGN.md, and demonstrably safer than the reference implementation.Product-by-product plan
.artifacts/, upload them as GitHub-hosted PR assets, add grouped screenshot evidence here, audit the staged diff, push, wait for every GitHub check, fix failures, and only then mark ready.Concrete defects already found during the expanded pass
This list is evidence of why the branch remains a draft, not a claim that the work is complete.
Final evidence (pending exact-build gate)
Final commands, test counts, browser measurements, hosted screenshots, CI links, and the staged-file audit will replace this section after all work above is accepted. Screenshots will not be committed to the repository.
Reference-only prior experiments: #679, #686.
Closes #538