changes as requested. #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjurado01
requested changes
Oct 16, 2019
| http.use_ssl = true | ||
| request = Net::HTTP::Get.new(uri.request_uri) | ||
| response = http.request(request) | ||
| keys = JSON.parse(response.body)['keys'] |
There was a problem hiding this comment.
This code is duplicated. I think that it's better to create a private function like this:
def make_get_request(url)
uri = URI(url)
http = Net::HTTP.new(uri.host, uri.port)
http.use_ssl = true
request = Net::HTTP::Get.new(uri.request_uri)
response = http.request(request)
JSON.parse(response.body)
end
| rescue => error | ||
| Rails.logger.info(error) if defined? Rails | ||
| end | ||
|
|
There was a problem hiding this comment.
Restore this line please. We always put empty line before and after a block.
| uri = URI.parse(config_uri) | ||
| http = Net::HTTP.new(uri.host, uri.port) | ||
| http.use_ssl = true | ||
| request = Net::HTTP::Get.new(uri.request_uri) |
There was a problem hiding this comment.
I think that you can pass uri directly: request = Net::HTTP::Get.new(uri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please let me know if you need additional changes. Thx.