Skip to content

feat: dark-themed dashboard mockup and router updates#8

Closed
poketonova wants to merge 23 commits into
mainfrom
feat/dashboard-mockup
Closed

feat: dark-themed dashboard mockup and router updates#8
poketonova wants to merge 23 commits into
mainfrom
feat/dashboard-mockup

Conversation

@poketonova

Copy link
Copy Markdown
Collaborator

Summary

This PR introduces a new dark-themed dashboard mockup and routing updates to the Rarebox collection tracker.

Key Features:

  • Dark-Themed UI: A sleek, high-contrast interface designed for modern collectors.
  • Glassmorphism Components: Utilizes frosted glass effects and subtle gradients for a premium, tactile feel.
  • Local-First Performance: Built for speed with minimal external dependencies, ensuring a snappy user experience.
  • Routing: Updated src/router/index.js to include the /mockup path for easy previewing.

The mockup can be viewed at /mockup once deployed.

…ers (#1)

* feat: replace unicode icons with inline SVGs and increase mobile touch targets in App.vue

* feat: add shimmer skeleton loaders and fluid grids in SetsView.vue

* fix: add accessibility attributes, update decks icon, and respect reduced motion in App.vue

* fix: add accessibility attributes and respect reduced motion in SetsView.vue
feat: Bulk selection and deletion for portfolios
fix: improve chart reliability and sparse data handling
@vercel

vercel Bot commented Jun 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pokemon-collectr Ready Ready Preview, Comment Jun 7, 2026 9:50pm

@novaoc

novaoc commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Reviewed + built locally. Not mergeable as-is — a crash bug, several regressions, and it's built on a stale base. Currently CONFLICTING with main.

🔴 Crash on mount (HIGH). src/components/scanner/CameraViewfinder.vue declares defineProps({ isProcessing: { type: BOOLEAN } }). BOOLEAN is undefined in JS (should be Boolean) → ReferenceError when the component evaluates. Any view that mounts it (PortfolioView does) crashes. Build/Vercel pass because it only throws at runtime.

🔴 Regressions vs current main:

  • MockDashboard.vue: main has evolved this into Search + Deck Builder views (/mockup). This PR overwrites it with a different Landing/Dashboard/Scanner feature set → it would drop main's work.
  • package.json downgrades: apexcharts ^5.10.5 → ^3.45.0 and vite ^8.0.4 → ^6.0.4 — clear evidence the branch is on a stale base. These are regressions.
  • Router: swaps createWebHistory → createWebHashHistory — a repo-wide routing change bundled into a "dashboard mockup" PR (unrelated, conflicts with main).
  • TradeAnalyzerView.vue: comments out the CameraViewfinder import ("doesn't exist in the repo" — but it would, from this same PR) and replaces store-backed logic with local refs + a dead Search @click.

🟡 getMarketPrice shape mismatch in scanPipeline.js (reads market.price, but the helper returns null | bare number | {price}) → silent 0 prices.

The genuinely useful bits: this PR adds tesseract.js + vite.config.js worker/optimizeDeps config + scanPipeline.js + a CameraViewfinder.vue — which is exactly what main's orphaned TradeAnalyzerView.vue is missing (main imports scanPipeline/CameraViewfinder that don't exist there). So there's real value here, but it's tangled with the regressions above.

Also conflicts with PR #5 (both edit PortfolioView.vue) and PR #4 (both add a divergent CameraViewfinder/TradeAnalyzerView).

Recommendation: this needs a rebase onto current main + decisions, not a merge. Concretely: fix BOOLEAN→Boolean, drop the dep downgrades + hash-router change, keep main's MockDashboard, fix the getMarketPrice shape, and reconcile with whichever scanner direction you pick (this vs PR #4). The scanner/trade feature should land as ONE coherent piece. Didn't close it — it has salvageable parts and needs your direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants