modules: power: add extra battery state to message #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahp
approved these changes
Oct 2, 2025
gminn
force-pushed
the
gminn/add-extra-battery-state-info
branch
from
2d8635c to
1e8f41c
Compare
jtguggedal
reviewed
Oct 6, 2025
gminn
force-pushed
the
gminn/add-extra-battery-state-info
branch
2 times, most recently
from
b4ebb4e to
63e4ea9
Compare
Add extra battery state information to the power module message: - Voltage - Whether the battery is charging or not This data is generally useful to get the full picture of battery state. For testing, a new shell command is now available to trigger a power sample: ``` uart:~$ att_power sample Requesting battery sample... [00:01:41.007,843] <inf> power: Battery state of charge: 100.00% [00:01:41.007,873] <inf> power: Battery voltage: 4.19V [00:01:41.007,904] <inf> power: Charging: No ``` Signed-off-by: Gillian Minnehan <[email protected]>
gminn
force-pushed
the
gminn/add-extra-battery-state-info
branch
from
63e4ea9 to
89a9217
Compare
|
|
@gminn lgtm, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra battery state information to the power module message:
This data is generally useful to get the full picture of battery state.
For testing, a new shell command is now available to trigger a power
sample:
Signed-off-by: Gillian Minnehan [email protected]