[DNM] [nrf toup] Network Commissioning: Add hysteresis to status reporting#620
Open
LuDuda wants to merge 1 commit intonrfconnect:masterfrom
Open
[DNM] [nrf toup] Network Commissioning: Add hysteresis to status reporting#620LuDuda wants to merge 1 commit intonrfconnect:masterfrom
LuDuda wants to merge 1 commit intonrfconnect:masterfrom
Conversation
This patch delays error reporting in NetworkCommissioning cluster if a success was recently observed, premature notifications to mislead clients. Functionality is controlled by CHIP_CONFIG_NETWORK_COMMISSIONING_IMMEDIATE_STATUS_REPORTING Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no>
LuDuda
commented
Jun 23, 2025
| * Default: 1 (enabled) | ||
| */ | ||
| #ifndef CHIP_CONFIG_NETWORK_COMMISSIONING_IMMEDIATE_STATUS_REPORTING | ||
| #define CHIP_CONFIG_NETWORK_COMMISSIONING_IMMEDIATE_STATUS_REPORTING 0 |
Collaborator
Author
There was a problem hiding this comment.
Note: Disabled for CI testing of a new behavior.
|
This pull request has been automatically marked as stale because it has not had recent activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a PoC for delaying reporting the error status - for review.
This patch delays error reporting in NetworkCommissioning cluster if a success was recently observed, premature notifications to mislead clients. Functionality is controlled by
CHIP_CONFIG_NETWORK_COMMISSIONING_IMMEDIATE_STATUS_REPORTING