tests: unittest: adding unit tests for ble_gq lib #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added unit tests for ble_gq library Signed-off-by: Nirmal Krishna <[email protected]> Co-authored-by: Andreas Moltumyr <[email protected]>
|
You can find the documentation preview for this PR here. |
| uint16_t conn_handle = 0x0C4; | ||
|
|
||
| ble_evt.header.evt_id = BLE_GAP_EVT_DISCONNECTED; | ||
| ble_evt.evt.gap_evt.conn_handle = 0x0C4; |
There was a problem hiding this comment.
Nit: I would consider defining 0x0C4 somewhere and then reusing the definition in all the different occurrences, rather than hardcoding the value.
|
No milestone required for tests |
Comment on lines
+252
to
+254
| for (int i = 0; i < ble_gq.max_conns; i++) { | ||
| ble_gq.conn_handles[i] = i + 1; | ||
| } |
There was a problem hiding this comment.
We should not alter the ble_gq ourselves. Perhaps register up to max_conns handlers successfully, then see that the next fails?
Comment on lines
+295
to
+296
| sys_slist_init(&ble_gq.req_queue[0]); | ||
| sys_slist_append(&ble_gq.req_queue[0], &req.node); |
There was a problem hiding this comment.
There should be another way to append these than by altering the struct with slist. Use ble_gq_item_add()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for ble_gq library