-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Remove dk dependency #24788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove dk dependency #24788
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
99bf891
to
1afce77
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 2c78992339dbb690ca4a0fe3f94d17bb1fd8d7d8 more detailssdk-nrf:
matter:
Github labels
List of changed files detected by CI (17)
Outputs:ToolchainVersion: f66cf421f3 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-24788/nrf/releases_and_maturity/migration/migration_guide_3.2.html |
doc/nrf/releases_and_maturity/migration/migration_guide_3.2.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
15e6d3b
to
94f1314
Compare
+++++++++++ | ||
|
||
|no_changes_yet_note| | ||
* Removed dependencies to Nordic DK-specific configurations in Matter configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Removed dependencies to Nordic DK-specific configurations in Matter configurations. | |
* Removed dependencies on Nordic DK-specific configurations in Matter configurations. |
doc/nrf/releases_and_maturity/migration/migration_guide_3.2.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/migration/migration_guide_3.2.rst
Outdated
Show resolved
Hide resolved
94f1314
to
e54b89e
Compare
81ee51b
to
6aa386e
Compare
CHIP_WIFI cannot depend on DK, it must rely on WIFI_NRF70. Signed-off-by: Arkadiusz Balys <[email protected]>
6aa386e
to
53f8087
Compare
.. code-block:: console | ||
|
||
cmake -GNinja -Bbuild -DBOARD=nrf5340dk/nrf5340/cpuapp -DSHIELD=nrf7002ek -DFILE_SUFFIX=nrf70ek -DSB_CONFIG_WIFI_NRF70=y -DAPP_DIR=*app_path* *path_to_zephyr*/share/sysbuild | ||
cmake -GNinja -Bbuild -DBOARD=nrf5340dk/nrf5340/cpuapp -DSHIELD=nrf7002ek -DFILE_SUFFIX=nrf70ek -DSB_CONFIG_WIFI_NRF70=y-DAPP_DIR=*app_path* *path_to_zephyr*/share/sysbuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this adds a mistake
#. Write Kconfig files to enable all required Kconfig options for your board. | ||
#. If you want to build your custom board with nRF70 Wi-Fi support, set the :kconfig:option:`CONFIG_CHIP_WIFI` and :kconfig:option:`SB_CONFIG_WIFI_NRF70` Kconfig options to ``y``. | ||
#. If your device uses external flash, add its devicetree definition under the :file:`board/<board_name>_<soc_name>.overlay` file, and set ``nordic,pm-ext-flash`` in the devicetree's ``chosen`` configuration. | ||
#. Refer to the :ref:`ug_matter_device_advanced_kconfigs` user guide, create your list of advanced configurations for your board, and apply the selected Kconfig options in the :file:`board/<board_name>_<soc_name>.conf` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variant? Link to the zephyr docs where this is explained rather than regurgitate it wrongly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find an appropriate guide in Zephyr, but I've changed it.
A new guide is added to each sample and contains instruction on how to create a custom board and prepare it to work with Matter. Signed-off-by: Arkadiusz Balys <[email protected]>
53f8087
to
2c78992
Compare
No description provided.