Skip to content

Comments

applications: nrf5340_audio: Remove CONFIG_BT_AUDIO_BITRATE_UNICAST_SINK#26402

Closed
gWacey wants to merge 1 commit intonrfconnect:mainfrom
gWacey:OCT-3006-Cannot-set-bitrate-for-unicast-client-through-CONFIG_BT_AUDIO_BITRATE_UNICAST_SINK
Closed

applications: nrf5340_audio: Remove CONFIG_BT_AUDIO_BITRATE_UNICAST_SINK#26402
gWacey wants to merge 1 commit intonrfconnect:mainfrom
gWacey:OCT-3006-Cannot-set-bitrate-for-unicast-client-through-CONFIG_BT_AUDIO_BITRATE_UNICAST_SINK

Conversation

@gWacey
Copy link
Contributor

@gWacey gWacey commented Jan 5, 2026

OCT-3006

The BAP presets are covering enough. It’s not really up to the unicast client to decide, as the server needs to have the specific bitrate in its PAC records anyway.

Hence removing references to CONFIG_BT_AUDIO_BITRATE_UNICAST_SINK.

@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 5, 2026
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 5, 2026

CI Information

To view the history of this post, click the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 594a23d0e32717096c82a70a6eec59ea3bf999e2

more details

sdk-nrf:

PR head: 594a23d0e32717096c82a70a6eec59ea3bf999e2
merge base: baa0a033b1b1d16fad1c1746fe243009860827ce
target head (main): 04ef67414c6253f403f8e0eaaac2a90101e85660
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
applications
│  ├── nrf5340_audio
│  │  ├── src
│  │  │  ├── bluetooth
│  │  │  │  ├── bt_stream
│  │  │  │  │  ├── unicast
│  │  │  │  │  │  ├── Kconfig
│  │  │  │  │  │  │ unicast_client.h

Outputs:

Toolchain

Version: f911d4f4e7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f911d4f4e7_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 12
  • ✅ Integration tests
    • ✅ test-sdk-audio
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

You can find the documentation preview for this PR here.

@gWacey gWacey added the DNM label Jan 5, 2026
@gWacey gWacey marked this pull request as ready for review January 6, 2026 08:24
@gWacey gWacey requested review from a team as code owners January 6, 2026 08:24
@gWacey gWacey removed the DNM label Jan 6, 2026
Copy link
Contributor

@koffes koffes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a sync tomorrow.

We may be able to remove BT_AUDIO_BITRATE_UNICAST_SRC and SINK as well.

@gWacey gWacey force-pushed the OCT-3006-Cannot-set-bitrate-for-unicast-client-through-CONFIG_BT_AUDIO_BITRATE_UNICAST_SINK branch from 6c1d4be to 622845b Compare January 7, 2026 10:05
@gWacey gWacey requested a review from koffes January 8, 2026 13:57
The BAP presets are covering enough. It’s not really up to the
unicast client to decide, as the server needs to have the
specific bitrate in its PAC records anyway.
Hence removing references to CONFIG_BT_AUDIO_BITRATE_UNICAST_SINK.

Signed-off-by: Graham Wacey <graham.wacey@nordicsemi.no>
@gWacey gWacey force-pushed the OCT-3006-Cannot-set-bitrate-for-unicast-client-through-CONFIG_BT_AUDIO_BITRATE_UNICAST_SINK branch from 622845b to 594a23d Compare January 8, 2026 14:08
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Feb 8, 2026
@github-actions github-actions bot closed this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants