Skip to content

Test commit #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Draft

Test commit #3146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/zephyr/arch/arm/error.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
*/
#define ARCH_EXCEPT(reason_p) \
do {\
while(1) {}; \

Check failure on line 38 in include/zephyr/arch/arm/error.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

TRAILING_STATEMENTS 

include/zephyr/arch/arm/error.h:38  trailing statements should be on next line

Check failure on line 38 in include/zephyr/arch/arm/error.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

SPACING 

include/zephyr/arch/arm/error.h:38  space required before the open parenthesis '('
arch_irq_unlock(0); \
__asm__ volatile( \
"mov r0, %[_reason]\n" \
Expand All @@ -42,7 +43,7 @@
:: [_reason] "r" (reason_p), [id] "i" (_SVC_CALL_RUNTIME_EXCEPT) \
: "r0", "memory"); \
} while (false)
#elif defined(CONFIG_ARMV7_R) || defined(CONFIG_AARCH32_ARMV8_R) \

Check notice on line 46 in include/zephyr/arch/arm/error.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

include/zephyr/arch/arm/error.h:46 
-#define ARCH_EXCEPT(reason_p) \
-do {\
-	while(1) {}; \
-	arch_irq_unlock(0); \
-	__asm__ volatile( \
-		"mov r0, %[_reason]\n" \
-		"svc %[id]\n" \
-		:: [_reason] "r" (reason_p), [id] "i" (_SVC_CALL_RUNTIME_EXCEPT) \
-		: "r0", "memory"); \
-} while (false)
+#define ARCH_EXCEPT(reason_p)                                                                      \
+	do {                                                                                       \
+		while (1) {                                                                        \
+		};                                                                                 \
+		arch_irq_unlock(0);                                                                \
+		__asm__ volatile("mov r0, %[_reason]\n"                                            \
+				 "svc %[id]\n" ::[_reason] "r"(reason_p),                          \
+				 [id] "i"(_SVC_CALL_RUNTIME_EXCEPT)                                \
+				 : "r0", "memory");                                                \
+	} while (false)
|| defined(CONFIG_ARMV7_A)
/*
* In order to support using svc for an exception while running in an
Expand Down
4 changes: 2 additions & 2 deletions modules/hal_nordic/nrf_802154/include/nrf_802154_assert_zephyr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
extern void nrf_802154_assert_handler(void);

#define NRF_802154_ASSERT(condition) \
do { \
if (!(condition)) { \
do { \
if (!(condition)) { while(1) {}; \

Check failure on line 22 in modules/hal_nordic/nrf_802154/include/nrf_802154_assert_zephyr.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

TRAILING_STATEMENTS 

modules/hal_nordic/nrf_802154/include/nrf_802154_assert_zephyr.h:22  trailing statements should be on next line

Check failure on line 22 in modules/hal_nordic/nrf_802154/include/nrf_802154_assert_zephyr.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

SPACING 

modules/hal_nordic/nrf_802154/include/nrf_802154_assert_zephyr.h:22  space required before the open parenthesis '('
nrf_802154_assert_handler(); \
} \
} while (0)

Check notice on line 25 in modules/hal_nordic/nrf_802154/include/nrf_802154_assert_zephyr.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

modules/hal_nordic/nrf_802154/include/nrf_802154_assert_zephyr.h:25 
-#define NRF_802154_ASSERT(condition) \
-	do {                            \
-		if (!(condition)) {  while(1) {};         \
-			nrf_802154_assert_handler(); \
-		}                            \
+#define NRF_802154_ASSERT(condition)                                                               \
+	do {                                                                                       \
+		if (!(condition)) {                                                                \
+			while (1) {                                                                \
+			};                                                                         \
+			nrf_802154_assert_handler();                                               \
+		}                                                                                  \

#endif /* CONFIG_NRF_802154_ASSERT_ZEPHYR_MINIMAL */

Expand Down
Loading