Skip to content

[nrf noup] tests: jwt: Add crypto configuration #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vge0rge
Copy link
Contributor

@Vge0rge Vge0rge commented Aug 18, 2025

Add the required crypto configuration for the nrf_security to work with this sample. This is a noup because of two reasons: 1) There is a downstream symbol
2) The nrf_security defaults deviate from the upstream ones
regarding heap

Copy link
Contributor

@frkv frkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this very much, can't we just add these options upstream?

@Vge0rge
Copy link
Contributor Author

Vge0rge commented Aug 19, 2025

I don't like this very much, can't we just add these options upstream?

Well, that needs to contribute the changes to the mbedlts and zephyr project. I don't think that this is on scope here.

@tomi-font
Copy link
Contributor

Well, that needs to contribute the changes to the mbedlts and zephyr project. I don't think that this is on scope here.

No, I don't quite mean to change how the configuration system works. Just to (more or less) literally make the same additions in Zephyr so that we don't need a noup. Even if they're not strictly required in Zephyr it can be okay to have extra config options in tests. I've already successfully done that.

@Vge0rge
Copy link
Contributor Author

Vge0rge commented Aug 20, 2025

Well, that needs to contribute the changes to the mbedlts and zephyr project. I don't think that this is on scope here.

No, I don't quite mean to change how the configuration system works. Just to (more or less) literally make the same additions in Zephyr so that we don't need a noup. Even if they're not strictly required in Zephyr it can be okay to have extra config options in tests. I've already successfully done that.

But what I am saying here is that one Kconfig is only downstream, it does not exist in Zephyr or Mbedlts. So this cannot be upstreamed because it will break the break the Zephyr CI since the Kconfig doesn't exist, right?

@tomi-font
Copy link
Contributor

But what I am saying here is that one Kconfig is only downstream, it does not exist in Zephyr or Mbedlts. So this cannot be upstreamed because it will break the break the Zephyr CI since the Kconfig doesn't exist, right?

ah 🥵 annoying

Add the required crypto configuration for the nrf_security
to work with this sample. This is a noup because of two reasons:
1) There is a downstream symbol
2) The nrf_security defaults deviate from the upstream ones
regarding heap

Signed-off-by: Georgios Vasilakis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants