-
Notifications
You must be signed in to change notification settings - Fork 694
[nrf noup] tests: jwt: Add crypto configuration #3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this very much, can't we just add these options upstream?
Well, that needs to contribute the changes to the mbedlts and zephyr project. I don't think that this is on scope here. |
No, I don't quite mean to change how the configuration system works. Just to (more or less) literally make the same additions in Zephyr so that we don't need a noup. Even if they're not strictly required in Zephyr it can be okay to have extra config options in tests. I've already successfully done that. |
But what I am saying here is that one Kconfig is only downstream, it does not exist in Zephyr or Mbedlts. So this cannot be upstreamed because it will break the break the Zephyr CI since the Kconfig doesn't exist, right? |
ah 🥵 annoying |
Add the required crypto configuration for the nrf_security to work with this sample. This is a noup because of two reasons: 1) There is a downstream symbol 2) The nrf_security defaults deviate from the upstream ones regarding heap Signed-off-by: Georgios Vasilakis <[email protected]>
Add the required crypto configuration for the nrf_security to work with this sample. This is a noup because of two reasons: 1) There is a downstream symbol
2) The nrf_security defaults deviate from the upstream ones
regarding heap