Skip to content

[dnm] update boot report with uuid field #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Draft

[dnm] update boot report with uuid field #3208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions soc/nordic/ironside/include/nrf_ironside/boot_report.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
#define IRONSIDE_BOOT_REPORT_LOCAL_DOMAIN_CONTEXT_SIZE (16UL)
/** Length of the random data buffer in bytes. */
#define IRONSIDE_BOOT_REPORT_RANDOM_DATA_SIZE (32UL)

/** Length of the uuid data field in bytes. */

Check warning on line 18 in soc/nordic/ironside/include/nrf_ironside/boot_report.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LONG_LINE_COMMENT 

soc/nordic/ironside/include/nrf_ironside/boot_report.h:18  line length of 128 exceeds 100 columns

Check failure on line 18 in soc/nordic/ironside/include/nrf_ironside/boot_report.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

TRAILING_WHITESPACE 

soc/nordic/ironside/include/nrf_ironside/boot_report.h:18  trailing whitespace
#define SECDOM_BOOT_REPORT_UUID_SIZE (16UL)

Check notice on line 19 in soc/nordic/ironside/include/nrf_ironside/boot_report.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

soc/nordic/ironside/include/nrf_ironside/boot_report.h:19 
-/** Length of the uuid data field in bytes. */                                                                                  
+/** Length of the uuid data field in bytes. */
/** @brief IronSide version structure. */
struct ironside_version {
/** Wrapping sequence number ranging from 1-126, incremented for each release. */
Expand Down Expand Up @@ -59,8 +60,10 @@
uint8_t local_domain_context[IRONSIDE_BOOT_REPORT_LOCAL_DOMAIN_CONTEXT_SIZE];
/** CSPRNG data */
uint8_t random_data[IRONSIDE_BOOT_REPORT_RANDOM_DATA_SIZE];
/** Device Info data : 128-bit Universally Unique IDentifier (UUID) */

Check warning on line 63 in soc/nordic/ironside/include/nrf_ironside/boot_report.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LONG_LINE_COMMENT 

soc/nordic/ironside/include/nrf_ironside/boot_report.h:63  line length of 125 exceeds 100 columns

Check failure on line 63 in soc/nordic/ironside/include/nrf_ironside/boot_report.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

TRAILING_WHITESPACE 

soc/nordic/ironside/include/nrf_ironside/boot_report.h:63  trailing whitespace
uint8_t device_info_uuid[SECDOM_BOOT_REPORT_UUID_SIZE];

Check warning on line 64 in soc/nordic/ironside/include/nrf_ironside/boot_report.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

LEADING_SPACE 

soc/nordic/ironside/include/nrf_ironside/boot_report.h:64  please, no spaces at the start of a line
/** Reserved for Future Use */

Check notice on line 65 in soc/nordic/ironside/include/nrf_ironside/boot_report.h

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

You may want to run clang-format on this change 

soc/nordic/ironside/include/nrf_ironside/boot_report.h:65 
-    /** Device Info data : 128-bit Universally Unique IDentifier (UUID) */                                                   
-    uint8_t device_info_uuid[SECDOM_BOOT_REPORT_UUID_SIZE];
+	/** Device Info data : 128-bit Universally Unique IDentifier (UUID) */
+	uint8_t device_info_uuid[SECDOM_BOOT_REPORT_UUID_SIZE];
uint32_t rfu[64];
uint32_t rfu[60];
};

/**
Expand Down
Loading