Skip to content

216 expose metrics #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

216 expose metrics #233

wants to merge 3 commits into from

Conversation

@stigok
Copy link
Contributor

@stigok stigok commented Feb 22, 2024 •
edited
Loading

Implements #216

@github-actions
Copy link
Contributor

Fuzz test failed on 1b44450. To troubleshoot locally, use the GitHub CLI to download the seed corpus with

gh run download 8007743296 -n testdata

1 similar comment
@github-actions
Copy link
Contributor

Fuzz test failed on 1b44450. To troubleshoot locally, use the GitHub CLI to download the seed corpus with

gh run download 8007743296 -n testdata

@github-actions
Copy link
Contributor

Fuzz test failed on e90dd54. To troubleshoot locally, use the GitHub CLI to download the seed corpus with

gh run download 8008399639 -n testdata

@github-actions
Copy link
Contributor

You have commit message errors, your commit messages
must follow conventional commits

To correct, run git rebase -i HEAD~X, where X is number of commits, and change from pick to reword, save, and then change the commit message.

List of errors:
Commit e0ac123, message DONOTMERGE: one way to do metrics
⧗ type must be lower-case⧗ type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]

Commit e90dd54, message DONOTMERGE: keep metrics local to the struct instance
⧗ type must be lower-case⧗ type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]

@stigok stigok force-pushed the 216-expose-metrics branch from e90dd54 to 67a2064 Compare February 26, 2024 08:50
@github-actions
Copy link
Contributor

You have commit message errors, your commit messages
must follow conventional commits

To correct, run git rebase -i HEAD~X, where X is number of commits, and change from pick to reword, save, and then change the commit message.

List of errors:
Commit a257104, message DONOTMERGE: one way to do metrics
⧗ type must be lower-case⧗ type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]

Commit 67a2064, message DONOTMERGE: keep metrics local to the struct instance
⧗ type must be lower-case⧗ type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test]

@stigok stigok force-pushed the 216-expose-metrics branch 2 times, most recently from a2db880 to f43be1e Compare February 27, 2024 07:40
@stigok
refactor: extract ListenAndServe to function
b7e28e8
@stigok
feat!: add prometheus metrics support
5312f4b 
- Add arguments `-prometheus-metrics-enabled` and
  `-prometheus-listen-addr` to control whether to expose metrics from
  the registry app.
- The `ModuleStore` interface has received an extra method `Metrics()`
  to support store-specific metrics.
@stigok
feat(store/github): expose github store metrics
8f723db 
Currently exposes rate limit status towards the GitHub API. These
metrics are polled from the GitHub API on regular intervals. These
requests are exempted from the general rate limits.

The worker for polling this status is not started until the first call
to `ReloadCache`.

https://docs.github.com/en/rest/rate-limit/rate-limit?apiVersion=2022-11-28#get-rate-limit-status-for-the-authenticated-user
@stigok stigok force-pushed the 216-expose-metrics branch from f43be1e to 8f723db Compare February 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stigok