Skip to content

Conversation

Turalchik
Copy link
Contributor

@Turalchik Turalchik commented Sep 10, 2025

Close #3990.
Close #3992.

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 88.57143% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.06%. Comparing base (08aaef3) to head (a5e223e).
⚠️ Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
pkg/rpcclient/policy/policy.go 81.81% 4 Missing and 2 partials ⚠️
pkg/core/native/policy.go 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4004      +/-   ##
==========================================
+ Coverage   82.04%   82.06%   +0.01%     
==========================================
  Files         351      351              
  Lines       50035    50109      +74     
==========================================
+ Hits        41051    41120      +69     
- Misses       7255     7258       +3     
- Partials     1729     1731       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Turalchik Turalchik force-pushed the protocol-updates branch 3 times, most recently from ec9d63d to a7d1aea Compare September 16, 2025 12:38
@Turalchik Turalchik force-pushed the protocol-updates branch 4 times, most recently from 0e3a154 to dafb91f Compare September 18, 2025 08:17
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is not finished yet, PR was updated.

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A common note: if some functionality/doc is already implemented, then follow the established style of the code/comments/docs. Don't make tests or code complicated, try to keep the code simple and readable. Try to avoid long variable names, try to keep the names meaningful only if these variables are important.

These rules make the codebase maintenance process easier, it's especially important for large codebases.

@Turalchik Turalchik force-pushed the protocol-updates branch 7 times, most recently from 0ec375f to ed9f9ff Compare September 18, 2025 19:19
@Turalchik Turalchik force-pushed the protocol-updates branch 4 times, most recently from af0e860 to f0ee00d Compare September 22, 2025 09:47
@Turalchik Turalchik force-pushed the protocol-updates branch 4 times, most recently from 42b5d7c to 5efdc49 Compare September 23, 2025 10:35
@Turalchik Turalchik force-pushed the protocol-updates branch 3 times, most recently from 20b043f to d371331 Compare September 23, 2025 15:13
A part of #3992.

Signed-off-by: Tural Devrishev <[email protected]>
A part of #3992.

Signed-off-by: Tural Devrishev <[email protected]>
Tural Devrishev added 3 commits September 23, 2025 19:32
A part of #3992.

Signed-off-by: Tural Devrishev <[email protected]>
A part of #3992.

Signed-off-by: Tural Devrishev <[email protected]>
A part of #3990.

Signed-off-by: Tural Devrishev <[email protected]>
Tural Devrishev added 3 commits September 23, 2025 19:38
A part of #3990.

Signed-off-by: Tural Devrishev <[email protected]>
A part of #3990.

Signed-off-by: Tural Devrishev <[email protected]>
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@AnnaShaleva AnnaShaleva merged commit bdb0d70 into master Sep 23, 2025
32 checks passed
@AnnaShaleva AnnaShaleva deleted the protocol-updates branch September 23, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Policy's getBlockedAccounts API Port StdLib's hexEncode and hexDecode APIs
2 participants