-
Notifications
You must be signed in to change notification settings - Fork 94
core: port StdLib's hexEncode, hexDecode and Policy's getBlockedAccounts APIs #4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4004 +/- ##
==========================================
+ Coverage 82.04% 82.06% +0.01%
==========================================
Files 351 351
Lines 50035 50109 +74
==========================================
+ Hits 41051 41120 +69
- Misses 7255 7258 +3
- Partials 1729 1731 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ec9d63d
to
a7d1aea
Compare
a7d1aea
to
4cc02d7
Compare
0e3a154
to
dafb91f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review is not finished yet, PR was updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A common note: if some functionality/doc is already implemented, then follow the established style of the code/comments/docs. Don't make tests or code complicated, try to keep the code simple and readable. Try to avoid long variable names, try to keep the names meaningful only if these variables are important.
These rules make the codebase maintenance process easier, it's especially important for large codebases.
0ec375f
to
ed9f9ff
Compare
af0e860
to
f0ee00d
Compare
42b5d7c
to
5efdc49
Compare
20b043f
to
d371331
Compare
A part of #3992. Signed-off-by: Tural Devrishev <[email protected]>
d371331
to
252405c
Compare
A part of #3992. Signed-off-by: Tural Devrishev <[email protected]>
252405c
to
04dfb9b
Compare
A part of #3992. Signed-off-by: Tural Devrishev <[email protected]>
A part of #3992. Signed-off-by: Tural Devrishev <[email protected]>
A part of #3990. Signed-off-by: Tural Devrishev <[email protected]>
5ce6b8a
to
ffb8461
Compare
A part of #3990. Signed-off-by: Tural Devrishev <[email protected]>
A part of #3990. Signed-off-by: Tural Devrishev <[email protected]>
A part of #3990. Signed-off-by: Tural Devrishev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Close #3990.
Close #3992.