sn/object: Forward original GET/HEAD/RANGE request to container members #3413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when proxy SN forwarded read object requests to the container, it updated the request as follows: 1. meta header was wrapped into the new one with decremented TTL; 2. verification header was wrapped into to the new one with added signatures for original parts. This resulted in the following costs: - additional calculation of two signatures on proxy SN; - more expensive request serialization, more data over the network; - more expensive request deserialization on container SN; - additional verification of two signatures on container SN. At the same time, apart from the mentioned actions, container SN did not use additional data for processing. So if a node doesn't update TTL and add signatures, then it's just reduces the resources spent without changing the behavior. This makes proxy SN to not resign object GET/HEAD/RANGE requests on forwarding. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
get-forwarding
branch
from
84f4a7f to
fcc9187
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3413 +/- ##
=======================================
Coverage 21.16% 21.16%
=======================================
Files 708 708
Lines 52881 52842 -39
=======================================
- Hits 11191 11185 -6
+ Misses 40895 40861 -34
- Partials 795 796 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i stick to the proposed change in cost/benefit ratio
at the same time, the explicit context of request forwarding is lost. I dont see a problem with this for now. If the need arises, I'd consider more lightweight approach than recursive headers