Add tests for Policer
#3556
Merged
Add tests for Policer
#3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
force-pushed
the
policer-tests
branch
from
1c5a223 to
071a5f8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3556 +/- ##
==========================================
+ Coverage 24.93% 25.60% +0.67%
==========================================
Files 660 661 +1
Lines 49356 49446 +90
==========================================
+ Hits 12307 12663 +356
+ Misses 36059 35777 -282
- Partials 990 1006 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prevent data race conditions for tests run with `-race` flag. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
policer-tests
branch
from
071a5f8 to
2811d4c
Compare
cthulhu-rider
requested review from
roman-khimov,
carpawell and
End-rey
as code owners
roman-khimov
reviewed
Sep 2, 2025
End-rey
reviewed
Sep 2, 2025
cthulhu-rider
force-pushed
the
policer-tests
branch
from
2811d4c to
09753dd
Compare
|
fixed unadded files |
End-rey
approved these changes
Sep 2, 2025
roman-khimov
approved these changes
Sep 3, 2025
pkg/services/policer/policer_test.go
Outdated
| } | ||
| } | ||
| if expShortage > 0 { | ||
| require.Eventually(t, repTaskSubmitted, 300*time.Millisecond, 30*time.Millisecond) |
There was a problem hiding this comment.
300ms can be insufficient for busy GH runners.
There was a problem hiding this comment.
hmm, didn't think about it. How much u think to increase for better reliability?
There was a problem hiding this comment.
Something like 3s, shouldn't affect regular operation much, but should be sufficient to prevent false negatives as well.
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
policer-tests
branch
from
09753dd to
f50ff81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.