Added test for reproduction of rolling failure #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens when write/read operations are done concurrently and the queue buffer file is rolled
ploxiln
reviewed
Jul 5, 2022
|
|
||
| filepath.Walk(tmpDir, func(path string, info fs.FileInfo, err error) error { | ||
| if strings.HasSuffix(path, ".bad") { | ||
| t.FailNow() |
There was a problem hiding this comment.
can you also t.Logf() something here, like "found .bad chunk: ${path}"
There was a problem hiding this comment.
sure I can add this when I have some time but anyway this is just a draft PR not meant to be merged until the bug itself is fixed, it's a kinda TDD-approach to repro/prove there is a problem ;)
|
see #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when write/read operations are done concurrently and the queue buffer file is rolled