Skip to content

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Nov 27, 2023

Type of PR:

  • Refactor

Required reviews:

  • 3

What this does:

  • Replaces dependency on ethers-v5 with viem
  • Introduces signer-provider separation with WalletClient and PublicClient

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

@netlify
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for taco-nft-demo ready!

Name Link
🔨 Latest commit 1fb32bd
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/658447f8127d35000829180d
😎 Deploy Preview https://deploy-preview-421--taco-nft-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for taco-demo ready!

Name Link
🔨 Latest commit 1fb32bd
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/658447f858e6f10008518b45
😎 Deploy Preview https://deploy-preview-421--taco-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@piotr-roslaniec piotr-roslaniec force-pushed the viem branch 7 times, most recently from 271d364 to eb9cc4e Compare November 30, 2023 09:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (1a8c590) 88.00% compared to head (1fb32bd) 87.89%.

Files Patch % Lines
packages/taco/src/dkg.ts 33.33% 12 Missing ⚠️
packages/pre/src/policy.ts 42.85% 8 Missing ⚠️
packages/taco/src/taco.ts 82.05% 6 Missing and 1 partial ⚠️
packages/taco/src/conditions/context/providers.ts 92.20% 4 Missing and 2 partials ⚠️
packages/taco/src/tdec.ts 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
- Coverage   88.00%   87.89%   -0.12%     
==========================================
  Files          33       33              
  Lines        2702     2767      +65     
  Branches      233      239       +6     
==========================================
+ Hits         2378     2432      +54     
- Misses        293      300       +7     
- Partials       31       35       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotr-roslaniec
Copy link
Contributor Author

piotr-roslaniec commented Dec 21, 2023

Currently fails due to some incompatibility between viem EIP712 signer and verifier on Ursula's side

Error: Threshold of responses not met; TACo decryption failed with errors: {"0x210eeAC07542F815ebB6FD6689637D8cA2689392":"(<class 'nucypher.network.middleware.RestMiddleware.BadRequest'>, BadRequest('Invalid data provided for context variable: Invalid data provided for \":userAddress\"; KeyError - \\'name\\''), 
// abbreviated

@derekpierre
Copy link
Member

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants