Skip to content

Conversation

theref
Copy link
Contributor

@theref theref commented Aug 1, 2024

This is the same PR as #551. The previous PR was closed due to the destination branch being deleted.

Type of PR:

  • Documentation

Required reviews:

  • 2

Fixes https://github.com/nucypher/sprints/issues/27

@theref theref requested a review from derekpierre August 1, 2024 07:49
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for taco-nft-demo ready!

Name Link
🔨 Latest commit d2d5b86
🔍 Latest deploy log https://app.netlify.com/projects/taco-nft-demo/deploys/68ee6c3afa93460008d61af1
😎 Deploy Preview https://deploy-preview-562--taco-nft-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for taco-demo ready!

Name Link
🔨 Latest commit d2d5b86
🔍 Latest deploy log https://app.netlify.com/projects/taco-demo/deploys/68ee6c3aedb8c1000855381d
😎 Deploy Preview https://deploy-preview-562--taco-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.


3. User Context Management:

They help manage user context, specifically the `:userAddress` parameter. This includes handling authentication tokens and ensuring that users are authenticated only once for multiple actions.
Copy link
Member

@derekpierre derekpierre Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also the :userAddressExternalEIP4361 context variable.

It also uses an auth provider for generating the AuthSignature - https://github.com/nucypher/taco-web/blob/main/packages/taco-auth/src/providers/external-eip4361.ts#L6.

Side note: my goal is to update the API via #560 in the next sprint.

[The below test](https://github.com/nucypher/taco-web/blob/b689493a37bec0b168f80f43347818095c3dd5ce/packages/taco/test/conditions/context.test.ts#L382C1-L429C6) demonstrates how a SIWE message can be reused for TACo authentication.
This ensures that users don't have to sign multiple messages when logging into apps and decrypting TACo messages.

```typescript
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test in a test file somewhere already? Can we link to to test files/line numbers instead? That would ensure that the test always remains fresh. Some for other spots above.

Co-authored-by: Derek Pierre <[email protected]>
@derekpierre
Copy link
Member

Looks like this needs a rebase, which will have conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants