[DRAFT] Epic: viem + TacoClient + fix ES import issue #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taco-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for taco-nft-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Added eslint disable comments for necessary any types in dynamic viem type declarations - Fixed import order in examples and tests - Added file-level eslint disables for complex wrapper implementations - Resolved all lint errors while maintaining functionality
- Fixed eslint disable comment placement for any type assertions - Ensured all CI/CD lint checks pass successfully
(to prevent making unnecessary network calls)
Co-authored-by: Manuel Montenegro <[email protected]>
Co-authored-by: Derek Pierre <[email protected]>
Mainly reduce some validation and add provider chain id validation among the other edits including the tests and the .md files
Co-authored-by: Manuel Montenegro <[email protected]>
…and viem for the same private key can be properly tested. Fix bug in ViemSignerAdapter implementation where bytes were not being signed properly.
…ases for ethers and viem
…o all package.json files to expose TypeScript declarations
…import This is because import from 'ethers/lib/utils' causes compatibility issues with projects that uses ES Modules.
… failure case for unsupported networks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Just a collection of features implemented in other PRs created while working on Fileverse agents.
Issues fixed/closed:
Why it's needed:
Notes for reviewers: