-
Notifications
You must be signed in to change notification settings - Fork 24
Define Variable/Value operations that will be used before evaluation #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
derekpierre
merged 8 commits into
nucypher:signing-epic
from
derekpierre:variable-operations
Oct 15, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9b65b7f
Initial code for supporting variable operations as part of condition …
derekpierre 6e836b5
Initial tests for variable operation and its usage in return value te…
derekpierre 134ed21
Add integration test for variable operation usage; lingo and encrypt/…
derekpierre 6d1f44e
Add usage of variable operations in ReturnValueTest and ConditionVari…
derekpierre 66bd099
Add restriction on maximum number of operations that can be performed…
derekpierre 03c0d48
Rename constant for better clarity.
derekpierre 07865c4
Remove the use of ^= (pow) operation since it is no longer allowed du…
derekpierre bdb373d
Rerun schema generation script now that the ^= (pow) operator has bee…
derekpierre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 changes: 93 additions & 0 deletions
93
packages/taco/src/conditions/schemas/variable-operation.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| import { z } from 'zod'; | ||
|
|
||
| import { paramOrContextParamSchema } from './context'; | ||
|
|
||
| export const OPERATOR_FUNCTIONS = [ | ||
| '+=', | ||
| '-=', | ||
| '*=', | ||
| '/=', | ||
| '%=', | ||
| 'index', | ||
| 'round', | ||
| // operations that don't require 2nd value | ||
| 'abs', | ||
| 'avg', | ||
| 'ceil', | ||
| 'ethToWei', | ||
| 'floor', | ||
| 'len', | ||
| 'max', | ||
| 'min', | ||
| 'sum', | ||
| 'weiToEth', | ||
| // casting | ||
| 'bool', | ||
| 'float', | ||
| 'int', | ||
| 'str', | ||
| ] as const; | ||
|
|
||
| export const UNARY_OPERATOR_FUNCTIONS = [ | ||
| 'abs', | ||
| 'avg', | ||
| 'ceil', | ||
| 'ethToWei', | ||
| 'floor', | ||
| 'len', | ||
| 'max', | ||
| 'min', | ||
| 'sum', | ||
| 'weiToEth', | ||
| // casting | ||
| 'bool', | ||
| 'float', | ||
| 'int', | ||
| 'str', | ||
| ]; | ||
|
|
||
| export const variableOperationSchema = z | ||
| .object({ | ||
| operation: z.enum(OPERATOR_FUNCTIONS), | ||
| value: paramOrContextParamSchema.optional(), | ||
| }) | ||
| .refine( | ||
| (data) => { | ||
| if ( | ||
| UNARY_OPERATOR_FUNCTIONS.includes(data.operation) && | ||
| data.value !== undefined | ||
| ) { | ||
| return false; | ||
| } | ||
| return true; | ||
| }, | ||
| { | ||
| message: 'Value not allowed for this operation', | ||
| path: ['value'], | ||
| }, | ||
| ) | ||
| .refine( | ||
| (data) => { | ||
| if ( | ||
| !UNARY_OPERATOR_FUNCTIONS.includes(data.operation) && | ||
| data.value === undefined | ||
| ) { | ||
| return false; | ||
| } | ||
| return true; | ||
| }, | ||
| { | ||
| message: 'Value must be defined for operation', | ||
| path: ['value'], | ||
| }, | ||
| ) | ||
| .describe('An operation that can be performed on an obtained result.'); | ||
|
|
||
| export const MAX_VARIABLE_OPERATIONS = 5; | ||
|
|
||
| export const variableOperationsArraySchema = z | ||
| .array(variableOperationSchema) | ||
| .min(1) | ||
| .max(MAX_VARIABLE_OPERATIONS) | ||
| .optional() | ||
| .describe('Optional operations to perform on the obtained result'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.