Skip to content

Conversation

nahss
Copy link

@nahss nahss commented Jun 19, 2024

Hey nullccxsy, lovely submission I went through your dapp and noticed a few issues and optimizations. Below are some of the changes I made:

Summary of Changes

Bug Fixes & Improvements:

  • Improved Code Readability and Consistency: Enhanced the readability and consistency of the codebase.
  • Ensured Proper Destruction of Vectors: Implemented proper destruction of vectors to avoid memory leaks.
  • Added Assert Statements: Included assert statements to prevent misuse and ensure robust code execution.
  • Optimized Logic: Optimized some of the logic in functions for better performance.

New Features:

  • get_lottery_details: Added to fetch details of a specific lottery.
  • list_all_lotteries: Added to list all existing lotteries.
  • get_user_lottery_stubs: Added to fetch all lottery stubs owned by a user.
  • extend_lottery: Added to extend the duration of an existing lottery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant