Fix AdditionalItemProperty hydration and declare ext-libxml requirement - #172
Open
jpvdw86 wants to merge 4 commits into
Open
Fix AdditionalItemProperty hydration and declare ext-libxml requirement#172jpvdw86 wants to merge 4 commits into
jpvdw86 wants to merge 4 commits into
Conversation
This is required to use LIBXML_PARSEHUGE in Reader.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency in AdditionalItemProperty deserialization and makes a runtime dependency explicit.
Item::getAdditionalItemProperties() is documented as returning AdditionalItemProperty[], but during XML parsing it could return raw Sabre array structures instead of typed objects.
Root cause: cac:AdditionalItemProperty was missing from Reader::ubl() elementMap.
Additionally, the reader uses LIBXML_PARSEHUGE, but ext-libxml was not explicitly declared in composer.json.