Skip to content

Implement the fmin and fmax ufuncs #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2025
Merged

Conversation

juntyr
Copy link
Contributor

@juntyr juntyr commented Jul 26, 2025

  • Implements the fmin and fmax ufuncs
  • Unblocks using np.nanmin and np.nanmax

@juntyr juntyr marked this pull request as draft July 26, 2025 14:43
@juntyr juntyr marked this pull request as ready for review July 27, 2025 15:23
@juntyr
Copy link
Contributor Author

juntyr commented Jul 27, 2025

?r @SwayamInSync

@SwayamInSync
Copy link
Collaborator

Thanks @juntyr , I wonder registering quad_minimum/maximum with fmin fmax ufuncs would've also worked?

@juntyr
Copy link
Contributor Author

juntyr commented Jul 27, 2025

Thanks @juntyr , I wonder registering quad_minimum/maximum with fmin fmax ufuncs would've also worked?

No, they have different NaN propagation behaviour. minimum/maximum propagates NaNs, fmin/fmax tries to avoid propagating them

@SwayamInSync
Copy link
Collaborator

No, they have different NaN propagation behaviour. minimum/maximum propagates NaNs, fmin/fmax tries to avoid propagating them

Ah yes I just noticed, thanks merging it

@SwayamInSync SwayamInSync merged commit 8fde328 into numpy:main Jul 27, 2025
6 checks passed
@juntyr juntyr deleted the fmin-fmax branch July 27, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants