fix(windows): path reducing for jest pattern#116
Open
eugeny-dementev wants to merge 1 commit intonvim-neotest:mainfrom
Open
fix(windows): path reducing for jest pattern#116eugeny-dementev wants to merge 1 commit intonvim-neotest:mainfrom
eugeny-dementev wants to merge 1 commit intonvim-neotest:mainfrom
Conversation
Contributor
|
I had the same issues with running the tests locally, raised an issue for it here #114 to try get some help from others. |
|
I'm using Neovim in Windows 11 with PowerShell 7.4.1 and it only works for me after I apply your code and remove the |
I've encountered the same issue. To fix this I've had to gsub out the backslash characters for it to work. It seems to normalize the path to C:\/....\/.... which windows does not like.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #113
There are few issues with it on windows:
vim.fn.expand("%")works on windows and unix:for file
__tests__/file.test.tsin nvim running command:lua =vim.fn.expand("%")will showunix:
__tests__/file.test.tswindows:
C:/project\__tests__/file.test.tsneotestuses that internal function to get current file and pass result to adaptersSolution in the PR is to reduce windows version of path to the same pattern it is for unix:
C:/project\__tests__/file.test.ts=>__tests__/file.test.ts.Fix is universal, on unix
vim.fn.substitute(string replace) just doesn't do anything since path already lackingcwdpartI've tested it on both windows and ubuntu and it seem to work as intended on both platforms
Help needed with writing tests because
./scripts/testthrows an error for me so I have no idea if I broke something