test: add missing context tests for existing queries#568
Merged
lewis6991 merged 3 commits intonvim-treesitter:masterfrom Apr 4, 2025
Merged
test: add missing context tests for existing queries#568lewis6991 merged 3 commits intonvim-treesitter:masterfrom
lewis6991 merged 3 commits intonvim-treesitter:masterfrom
Conversation
f4a750c to
8eab691
Compare
8eab691 to
b9151de
Compare
This was referenced Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #567, it is revealed that many queries are missing their respective context test files. With this, I wanted to go through the clean up of adding a context test for each existing query (with the exception of php_only and ocaml_interface). I also moved what seems to me are snapshot tests into their own directory to remove confusion between the purposes of the files and snapshot test failures. Through this exercise, I found that the tests are lacking in a couple of areas that I'll clean up in future PRs:
{{CONTEXT}}. it would make much more sense for me to mark all of the relevant lines. it would also be more immediately apparent for the person introducing the query if the multiline query is accepting too much (which is currently the problem with some languages)