feat(supercollider): added supercollider support#657
feat(supercollider): added supercollider support#657elgiano wants to merge 1 commit intonvim-treesitter:masterfrom
Conversation
elgiano
force-pushed
the
topic/supercollider
branch
from
49efda7 to
a9850fc
Compare
clason
force-pushed
the
topic/supercollider
branch
from
a9850fc to
8f3be17
Compare
|
This is a |
|
(I already rebased ;)) |
|
Just doing a change so README updates are required EDIT: #659 |
lewis6991
force-pushed
the
topic/supercollider
branch
from
368aba8 to
8a29917
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new queries/supercollider/context.scm file to enable treesitter-context support for the SuperCollider language. The file defines which tree-sitter node types should be captured as context (e.g., class definitions, function blocks, variable definitions) so that relevant scope information is shown when scrolling through SuperCollider code.
Changes:
- New
queries/supercollider/context.scmfile listing SuperCollider tree-sitter node types to capture as@context
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| [ | ||
| (function_block) | ||
| (binary_expression) | ||
| (collection) | ||
| (indexed_collection) | ||
| (parameter_call_list) | ||
| (function_call) | ||
| (class_def) | ||
| (classvar) | ||
| (const) | ||
| (instance_var) | ||
| (variable_definition) | ||
| (variable_definition_sequence) | ||
| (code_block) | ||
| ] @context |
There was a problem hiding this comment.
According to CONTRIBUTING.md (lines 58–78), a PR for supporting a new language requires both:
queries/[LANG]/context.scm(provided in this PR ✅)- A test file
test/lang/test.sc(ortest/lang/test.scd) with code examples annotated with{{TEST}},{{CONTEXT}}, and{{CURSOR}}directives ❌
No such test file exists for supercollider in test/lang/. The test infrastructure (test/contexts_spec.lua) will detect this as "No test file" and skip with a pending status, meaning no runtime coverage of the query is ever exercised. Please add a test file with representative SuperCollider code and the appropriate test markers so the context queries can be validated end-to-end.
| @@ -0,0 +1,15 @@ | |||
| [ | |||
There was a problem hiding this comment.
The PR title describes this as "update queries after breaking change", but the diff shows this file is being created fresh (diff starts from line 0, i.e., @@ -0,0 +1,15 @@). There is no previous version of queries/supercollider/context.scm in the repository — this is a brand new addition. The PR title and description should reflect that this is a new query file being added rather than an update to an existing one, or alternatively clarify what was previously attempted that is now being fixed.
elgiano
force-pushed
the
topic/supercollider
branch
from
8a29917 to
13afabb
Compare
elgiano
changed the title
|
I've renamed commit and pr messages, updated the README, and added some tests. I haven't run the tests yet though. EDIT: I've seen they fail in CI, I'll look more into them |
Updated queries after parser breaking change