rtc: allow rtc_read_alarm without read_alarm callback #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ Upstream commit a783c96 ] .read_alarm is not necessary to read the current alarm because it is recorded in the aie_timer and so rtc_read_alarm() will never call rtc_read_alarm_internal() which is the only function calling the callback. Reported-by: Zhipeng Wang <[email protected]> Reported-by: Marcel Ziswiler <[email protected]> Fixes: 7ae4122 ("rtc: introduce features bitfield") Tested-by: Philippe Schenker <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
Overdr0ne
pushed a commit
to Overdr0ne/linux-imx
that referenced
this pull request
Jul 28, 2025
…use those (nxp-imx#14) * dts: mt-connect: move pinctrl from gpio blocks to sai3 * dts: mt-connect: configure sai3 to use dummy clocks sai3 can select between 3 master clocks. Since we want to just use uboot’s clock configuration, and prevent the sai3 interface from changing that configuration, at least for now, all of those are configured as dummies, except for the bus clock, which may use the internal sai3 IPG clock, which is the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is needed to fix RTC wakealarm feature: adb shell "echo +20 > /sys/class/rtc/rtc0/wakealarm" on kernel 5.15
.read_alarm is not necessary to read the current alarm because it is recorded in the aie_timer and so rtc_read_alarm() will never call rtc_read_alarm_internal() which is the only function calling the callback.
Port of: 1e276e8