drm/of: prevent compiler warning #35
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark empty implementations of drm_of_component_probe_with_match as static inline. Prevents, if : | In file included from drivers/gpu/drm/drm_bridge.c:35: | ./include/drm/drm_of.h:88:12: error: 'drm_of_component_probe_with_match' defined but not used [-Werror=unused-function] | 88 | static int drm_of_component_probe_with_match(struct device *dev, Signed-off-by: Max Krummenacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building for x86-64 the compiler complains that drm_of_component_probe_with_match is defined but not used and the build fails as all warnings are treated as errors in that case.
Fix it by adding inline the same way as all other 'empty' functions are defined.
Reproduce: