Delegate objects are nullified in dealloc() method

[dodikk]

Since delegates are __unsafe_unretained they should be set to nil manually whenever a corresponding object is released.
I've added dealloc method to all classes where .delegate = self; statement is used.

• NXOAuth2Account
• NXOAuth2Request

The users have to do that as well, so this should be mentioned in the README, I guess.

Note : this pull request is based on from #155

[toto]

To keep in line with the framework this should be called NXOAuth2Application

[toto]

Generally we could convert the delegates to weak at some point. iOS 4 compatibility is really not that important anymore

[dodikk]

Generally we could convert the delegates to weak at some point.

That would be a lot better. Still, I did not feel confident enough to introduce such major changes since I have not fully understood the instance ownership model of the library. Neither I do now. Meaning, there are

• singletons
• properties to retain self

  OAuth2Client/Sources/OAuth2Client/NXOAuth2Request.m

  Line 27 in cf4d87f

  @property (nonatomic, strong, readwrite) NXOAuth2Request *me;

• etc.

So I've made the changes as conservative and safe as I could.

[dodikk]

P.S. Most of UIKit classes still use unsafe_unretained delegate properties for backward compatibility. UITableView, for example.

Moreover, it does not matter that much for this library since NSNotificationCenter is used for interactions with the client's code.

[toto]

True. You can use NXOAuth2Client on it's own without the NXOAuth2AccountStore and friends (indeed that was how it was first built) and in that case it works with delegates. If you use the higher level API as is appropriate in most use cases it's indeed not very relevant.

[sirnacnud]

I pushed up #204, making the delegates weak.