Skip to content

Conversation

simonwicky
Copy link
Contributor

@simonwicky simonwicky commented Aug 27, 2025

Description

Some AccountController tests seem to fail sometimes.
This PR aims to fix that by making the tests multi threaded allowing the AccountController to be moor free in a separate thread


This change is Reviewable

Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pronebird reviewed 3 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @simonwicky)

Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pronebird reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @simonwicky)

Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pronebird reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @simonwicky)

@simonwicky simonwicky force-pushed the simon/ac/multithread_tests branch from bf0af36 to 5cb48d2 Compare August 27, 2025 13:32
Copy link
Collaborator

@pronebird pronebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pronebird reviewed 2 of 2 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @simonwicky)

@simonwicky simonwicky closed this Sep 24, 2025
@simonwicky
Copy link
Contributor Author

Superseded by #3460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants