Rework for Client ID Prefix draft compatibility #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMissEm
force-pushed
the
feat/rework-for-client-id-prefix
branch
from
4b09863 to
52cffcc
Compare
|
@aaronpk you'll probably want to look at the rendered version of this when comparing. |
| The client metadata document MAY also be served with more specific content types | ||
| as long as the response is JSON and conforms to `application/<AS-defined>+json`. | ||
|
|
||
| All URLs contained within the Client ID Metadata Document must be absolute and |
There was a problem hiding this comment.
From an implementation standpoint, it is quite convenient to allow data: URLs.
Indeed, this allows the AS to serve UI without the need to proxy client defined assets (logo, privacy policy, ToS, etc.).
I mean it's fine if you want to leave data: as not recommended, but I would not put it in the same basket as javascript: that should probably be out right forbidden.
|
Have marked this as a draft given the status of Client ID Prefixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://drafts.aaronpk.com/oauth-client-id-prefix/draft-parecki-oauth-client-id-prefix.html
This also addresses the concerns in: