-
Notifications
You must be signed in to change notification settings - Fork 11
add note on CWT encoding #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cc @babisRoutis - couldn't request your review for some reason? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crystal clear 🔮
We should also clarify, that the CWT/JWT goes into the HTTP response body? |
That is why i added this sentence - I guess we could add the JWT one?
|
Yes, clarify further up for both JWT and CWT and have the reference to CWT encoding speed there as well. Let the now only talk about the hex encoding of examples underneath. |
Moved the whole note up - seemed more logical if we already state something about the body of the http response here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @c2bo
Now it looks even better.
Closes #302
Wording feels somewhat rough, but I think this is the best place to add that note. Any ideas to improve wording?