Skip to content

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Feb 17, 2022

Fixes #530.

I deleted 'synapse part' and its subclasses 'presynaptic membrane' and 'postsynaptic membrane'. None of them had any usages in axioms. I didn't see any automated way to regenerate the go_cc_import.owl.

@balhoff balhoff requested a review from matentzn February 17, 2022 15:50
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that none of these terms are used in ro-base.owl?

@balhoff
Copy link
Member Author

balhoff commented Feb 17, 2022

I looked at usages in ro-edit.owl within Protege. Shouldn't that be a superset of ro-base?

@matentzn
Copy link
Contributor

Yes it is! Thanks.

@balhoff
Copy link
Member Author

balhoff commented Feb 17, 2022

Wait—now I do see where this is "used":

synapsed_by_via_type_III_bouton expand expression to "BFO_0000051 some (GO_0042734 that BFO_0000050 some (GO_0045202 that BFO_0000051 some (GO_0097467 that BFO_0000051 some GO_0045211 that BFO_0000050 some ?Y)))"

@balhoff balhoff marked this pull request as draft February 17, 2022 15:59
@balhoff
Copy link
Member Author

balhoff commented Feb 17, 2022

I changed to draft to look at this a little further before merging.

@cmungall
Copy link
Contributor

any further thoughts @balhoff ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ro.owl is using GO:synapse part (GO:0044456) which is obsolete

3 participants