Remove Nix store path from source maps#1084
Open
isaac-uptrust wants to merge 1 commit intoobsidiansystems:developfrom
Open
Remove Nix store path from source maps#1084isaac-uptrust wants to merge 1 commit intoobsidiansystems:developfrom
isaac-uptrust wants to merge 1 commit intoobsidiansystems:developfrom
Conversation
Obelisk successfully serves minified JS, the corresponding unminified JS, and the source map that relates the two. But the source map's `sources` field contains the Nix store path of the unminified JS, not a URL. Browsers try to fetch the source code from a bogus URL: `https://example.com/nix/store/HASH-compressedJs/frontend.jsexe/all.unminified.js`. This change improves the situation by tweaking the arguments to `closure-compiler`; using relative paths to the JS files instead of absolute paths. Works on Chromium, but Firefox still has trouble.
isaac-uptrust
force-pushed
the
ie/fix-source-maps
branch
from
3f898da to
e5c61ed
Compare
Contributor
|
I just ran into this issue when i was profiling my code last week. Anything I can to do help get this merged? |
Contributor
Does this mean Firefox is kept the same as before the PR or does something get worse? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obelisk successfully serves minified JS, the corresponding unminified JS, and the source map that relates the two. But the source map's
sourcesfield contains the Nix store path of the unminified JS, not a URL. Browsers try to fetch the source code from a bogus URL:https://example.com/nix/store/HASH-compressedJs/frontend.jsexe/all.unminified.js.This change improves the situation by tweaking the arguments to
closure-compiler; using relative paths to the JS files instead of absolute paths.Works on Chromium, but Firefox still has trouble.