Fix opam dependencies to include ocamlbuild
#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you look at the [commit history](https://github.com/ocaml/opam-repository/commits/master/packages/ISO8601) of ISO8601 packages in the opam repository, you see that Fabrice fixed the dependencies for all releases upto 0.2.4, but that 0.2.5 was released with broken dependencies again. Let's make sure this does not happen anymore.
|
Note: this change was also part of #5. |
gasche
added a commit
to gasche/opam-repository
that referenced
this pull request
Feb 25, 2017
Previous opam files have been fixed by Fabrice, but the upstream opam was not changed, so this new version was proposed again with broken dependencies. I sent a PR upstream ( ocaml-community/ISO8601.ml#8 ) to make sure it does not happen again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look at the commit history of ISO8601 packages in the opam repository, you see that Fabrice fixed the dependencies for all releases upto 0.2.4, but that 0.2.5 was released with broken dependencies again. Let's make sure this does not happen anymore.