[5.4 compat] effects keyword can be an attribute id #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

EmileTrotignon wants to merge 1 commit into ocaml-ppx:main from EmileTrotignon:attr-effect

Collaborator

EmileTrotignon commented Jun 6, 2025

Address issue #2703

I added a test but I think its not great


          effects keyword can be an attribute id

159d518

EmileTrotignon added the no changelog label

Collaborator Author

EmileTrotignon commented Jun 6, 2025

No changelog because before effect was not a keyword and could therefore be used anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels