Package ISO8601.0.2.6 #14817
Merged
Package ISO8601.0.2.6 #14817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the toml tests wouldn't pass on the datakit machines with version 0.2.5 either. I'll work on merging a bugfix PR for 0.3, but 0.2.6 behaves exactly the same as previous versions except it builds with dune. (edit: there's a documented bug about daylight saving times in the library, which are computed in 1970 instead of at the given date; if datakit machines are in the UK it'd explain the bug, see the PR I will merge for 0.3) |
kit-ty-kate
reviewed
Sep 14, 2019
kit-ty-kate
reviewed
Sep 14, 2019
|
Otherwise it looks good |
Co-Authored-By: Kate <[email protected]>
Co-Authored-By: Kate <[email protected]>
|
Thanks! |
☀️ All lint checks passed ca8cd06
☀️ Installability check (+1)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISO8601.0.2.6ISO 8601 and RFC 3999 date parsing for OCaml
🐫 Pull-request generated by opam-publish v2.0.0