Fix Window compilation instructions for camlidl#29653
Open
yakobowski wants to merge 1 commit intoocaml:masterfrom
Open
Fix Window compilation instructions for camlidl#29653yakobowski wants to merge 1 commit intoocaml:masterfrom
yakobowski wants to merge 1 commit intoocaml:masterfrom
Conversation
Contributor
Author
|
Actually it's more complex than what I thought... |
yakobowski
force-pushed
the
camlidl
branch
4 times, most recently
from
0aff640 to
2a6d096
Compare
Use Makefile.unix for MinGW and Cygwin builds, and Makefile.win32 only for MSVC builds, distinguished via host-system-msvc. The previous configuration referenced a non-existent Makefile.mingw. Makefile.win32 uses CC=cl and MSVC flags, so it must not be used for MinGW/Cygwin which rely on a gcc-based toolchain like Makefile.unix. Also patch the source for GCC 14 compatibility on MinGW: - comerror.c: use caml_format_exception instead of the deprecated format_caml_exception (required under CAML_NAME_SPACE) - config/Makefile.unix: add -Wno-error=incompatible-pointer-types to CFLAGS to work around int/LONG mismatch in comintf.c Amp-Thread-ID: https://ampcode.com/threads/T-019d63cc-72f8-75f4-8999-2b6b29608ff4 Co-authored-by: Amp <amp@ampcode.com>
Contributor
Author
|
Fixed the errors coming from the switch to GCC 14 too. Not sure how you were planning to handle them repository-wise, but I wanted to test my patches. |
Contributor
Author
|
I had a look at the errors in opam-ci. They were either due to the switch to GCC 14, or unrelated to camlidl. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows Makefile extension is win32, not mingw