Misc: install completion

[hhugo]

No description provided.

[dbuenzli]

The Windows errors were weird.

Just out of curiosity, why did you use the opam & dune instructions rather than just dune?

[hhugo]

The Windows errors were weird.

Just out of curiosity, why did you use the opam & dune instructions rather than just dune?

I didn't know which one to choose. I wasn't sure the dune way was handling windows fine. Should I use the dune only instruction ?

[dbuenzli]

I didn't know which one to choose. I wasn't sure the dune way was handling windows fine

I have no idea :-) But it seems cmdliner has problem deriving the tool name from the executable path on windows (see linked cmdliner issue) I suspect you can work around by replacing:

"_build/install/default/bin/js_of_ocaml.exe" {os-family = "windows"} 

with the following syntax to set the tool name (see the description of the argument in cmdliner install tool-support --help) :

"_build/install/default/bin/js_of_ocaml.exe:js_of_ocaml" {os-family = "windows"} 

[dbuenzli]

The failure pattern is "interesting", but it seems the dune instructions trigger a bug in dune itself.

[WardBrian]

The failure pattern is "interesting", but it seems the dune instructions trigger a bug in dune itself.

The pattern used here is almost exactly what we use in stanc3.

Requesting dune build compiler/bin-js_of_ocaml/cmdliner-support compiler/bin-wasm_of_ocaml/cmdliner-support generates the expected files in the _build directory.

So, it seems like the issue comes specifically from specifying two share_root install targets with the (dir ...) atom.
Comment either one out and it will build, so at least we have a fairly specific bug to report...

[hhugo]

As a workaround, this PR now lists the directory generated by cmdliner and generate an install-in-share.sexp file that can be used in the install stanza

(install
 (section share_root)
 (package js_of_ocaml-compiler)
 (files
  (include install-in-share.sexp)))

[nojb]

Unfortunately, this PR does not seem enough to be able to build js_of_ocaml in a workspace (in a monorepo, without OPAM): ocaml/dune#13500.

[hhugo]

Can you check with https://github.com/ocsigen/js_of_ocaml/tree/fix-completion ? The downside is that it could break if cmdliner changes the set of files it generate.

[nojb]

Can you check with https://github.com/ocsigen/js_of_ocaml/tree/fix-completion ? The downside is that it could break if cmdliner changes the set of files it generate.

I confirm it works, thanks!

[hhugo]

Can you check with https://github.com/ocsigen/js_of_ocaml/tree/fix-completion ? The downside is that it could break if cmdliner changes the set of files it generate.

I confirm it works, thanks!

Do you need the fix the upcomming release ?

[nojb]

Can you check with https://github.com/ocsigen/js_of_ocaml/tree/fix-completion ? The downside is that it could break if cmdliner changes the set of files it generate.

I confirm it works, thanks!

Do you need the fix the upcomming release ?

If it is not too much work, that would be appreciated, yes. Otherwise, I will cherry-pick the fix. Thanks!

[hhugo]

I wonder if I should regenerate the file before building with opam to improve compatibility with different version of cmdliner