Conversation
Member
Author
|
@vouillon, can you check the failure below. see https://github.com/ocsigen/js_of_ocaml/actions/runs/22852044514/job/66282725911?pr=2195 |
3ee1415 to
b85ff80
Compare
vouillon
reviewed
Mar 10, 2026
hhugo
commented
Mar 10, 2026
| assert false | ||
| ;; | ||
|
|
||
| let () = test_iter_stream () |
Member
There was a problem hiding this comment.
We get a memory leak if we don't put the code in its own function since the head of the stream remains live.
Member
Author
|
@kit-ty-kate, you can update your alpha opam repo with the tip of this PR. |
5c40c3b to
0db9466
Compare
Contributor
done |
29334df to
218e9de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.