Fix collision of "i" at example in basics-server.wiki#38
Open
Yukimura66 wants to merge 1 commit intoocsigen:masterfrom
Open
Fix collision of "i" at example in basics-server.wiki#38Yukimura66 wants to merge 1 commit intoocsigen:masterfrom
Yukimura66 wants to merge 1 commit intoocsigen:masterfrom
Conversation
I found that following example in "Eliom: Typing page parameters" doesn't work.
```ocaml
let () =
Eliom_registration.Html.register ~service:myservice
(fun (s, i) () ->
Lwt.return
Eliom_content.Html.F.(html (head (title (txt "")) [])
(body [h1 [txt (s^string_of_int i)]])))
```
In definition of html, symbol `i` is used for parameter, but this collide to element for list item.
So I replaced symbol `i` to `num`, as following.
```ocaml
let () =
Eliom_registration.Html.register ~service:myservice
(fun (s, num) () ->
Lwt.return
Eliom_content.Html.F.(html (head (title (txt "")) [])
(body [h1 [txt (s^string_of_int num)]])))
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that following example in "Eliom: Typing page parameters" doesn't work.
In definition of html, symbol
iis used for parameter, but this collide to element for list item. So I replaced symbolitonum, as following.