Skip to content

Conversation

SylvainBoilard
Copy link

@SylvainBoilard SylvainBoilard commented Nov 4, 2024

@Drup
Copy link
Member

Drup commented Nov 8, 2024

Thanks !

If I'm reading the spec right, toggle is a valid event for any popover element ... which can be any HTML element. In that case, ontoggle should be a global attribute.

Is that right ? Can you do the modification accordingly ?

@SylvainBoilard SylvainBoilard changed the title Add name and ontoggle attributes for details HTML elements. Add support for the popover API and for the name attribute on <details> elements. Nov 14, 2024
@SylvainBoilard
Copy link
Author

Yes that is absolutely right; I had initially planned to limit the scope of this PR to the details element but following your input I decided to update it to support the popover API.

@SylvainBoilard SylvainBoilard changed the title Add support for the popover API and for the name attribute on <details> elements. Add support for the popover API and for the name attribute on details elements. Nov 14, 2024
@balat
Copy link
Member

balat commented May 2, 2025

Hello @Drup what do you think of the new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants