Fix #1887: cardDlg() should use cornerRadius from card size definition by kellyelton · Pull Request #2300 · octgn/OCTGN

kellyelton · 2026-03-25T19:50:21Z

Summary

Fixes #1887 — cardDlg() doesn't use cornerRadius from definition.xml when displaying cards.

Changes

Modified SetPicture in CardDlg.xaml.cs to apply a RectangleGeometry clip with the card's corner radius, scaled proportionally to the rendered image size (matching the approach used in CardControl).

If the card size has no corner radius defined (CornerRadius <= 0), behavior is unchanged
Uses a SizeChanged handler to apply the clip at the correct dimensions after layout
Radius is scaled relative to the defined card height vs actual rendered height, consistent with CardControl.xaml.cs

kellyelton · 2026-03-27T18:34:56Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T18:35:56Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Good code quality with proper null checks, resource management, and clean implementation of corner radius logic.

Level 2: Security Review ✅
No security concerns - UI rendering code with no user input handling or injection vectors.

Level 3: Requirements Review ✅
Directly addresses #1887 - implements cornerRadius support in cardDlg() as requested with proper scaling.

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T18:59:35Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T19:00:53Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Good implementation with proper null checks and SizeChanged event handling

Level 2: Security Review ✅
No security concerns - UI code only

Level 3: Requirements Review ✅
Directly addresses #1887 - implements cornerRadius support in cardDlg() as requested

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T20:41:58Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T20:42:42Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Good null checks, proper event handling, clean implementation that matches existing patterns.

Level 2: Security Review ✅
No security vulnerabilities, proper input handling for UI components.

Level 3: Requirements Review ✅
Directly addresses issue #1887 by implementing corner radius support in cardDlg().

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T21:05:25Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T21:06:21Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Good null handling and proper corner radius application using RectangleGeometry clipping.

Level 2: Security Review ✅
Pure UI changes with no security concerns - only corner radius clipping application.

Level 3: Requirements Review ✅
Fixes issue #1887 by correctly applying corner radius from card definition to CardDlg display.

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T21:46:18Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T21:47:13Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Good defensive programming with proper null checks and event handling.

Level 2: Security Review ✅
No security concerns identified in UI-only changes.

Level 3: Requirements Review ✅
Directly addresses issue #1887 by properly applying corner radius to CardDlg display.

All 3 review levels passed. Ready for merge. Note: Cannot auto-approve own PR - requires human review for approval.

kellyelton · 2026-03-27T22:41:04Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T22:43:43Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Good code quality with proper null checks and dynamic corner radius implementation

Level 2: Security Review ✅
No security concerns - uses standard WPF geometry and image handling

Level 3: Requirements Review ✅
Directly addresses #1887 - implements corner radius usage in cardDlg as requested

All 3 review levels passed. Ready for merge.

Note: Automated approval not available due to PR ownership constraints. Manual review recommended before merge.

kellyelton · 2026-03-27T23:13:18Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T23:14:03Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Correctly implements corner radius feature with proper null checks, event handling, and proportional scaling consistent with existing CardControl implementation.

Level 2: Security Review ✅
No security concerns - UI rendering code with no input validation or data handling risks.

Level 3: Requirements Review ✅
Directly addresses issue #1887 - implements corner radius usage in cardDlg as requested in the issue description.

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T23:40:51Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T23:41:22Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Clean UI enhancement that adds missing corner radius support to card dialog

Level 2: Security Review ✅
No security concerns; purely visual UI enhancement

Level 3: Requirements Review ✅
Directly addresses issue #1887 - implements missing corner radius support in card dialog

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-28T00:24:56Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-28T00:25:47Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Added proper null checks and dynamic corner radius clipping logic for card images.

Level 2: Security Review ✅
No security concerns - safe UI enhancement with proper input validation.

Level 3: Requirements Review ✅
Directly addresses issue #1887 - cardDlg() now uses cornerRadius from definition.xml.

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-28T02:02:41Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-28T02:03:54Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Good code quality with proper null checks, resource management, and clear logic

Level 2: Security Review ✅
No security vulnerabilities detected - UI code with proper input validation

Level 3: Requirements Review ✅
Directly addresses issue #1887 - implements corner radius functionality in cardDlg() using RectangleGeometry clip with proper scaling

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-28T02:38:29Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-28T02:39:00Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2300 — Fix #1887: cardDlg() should use cornerRadius from card size definition
Issue: #1887 — cardDlg() doesn't use cornerRadius

Level 1: Standard Code Review ✅
Clean implementation with proper null checks and event handling patterns.

Level 2: Security Review ✅
No security concerns in UI code changes.

Level 3: Requirements Review ✅
Directly addresses issue #1887 - implements corner radius functionality using RectangleGeometry with proper scaling.

All 3 review levels passed. Ready for merge.

Fix #1887: cardDlg() should use cornerRadius from card size definition

5d820f6

kellyelton added octgn-issue-bot PRs created by the OCTGN issue bot reviewing PR is currently being reviewed by the automated reviewer labels Mar 25, 2026

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton added reviewing PR is currently being reviewed by the automated reviewer and removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed reviewing PR is currently being reviewed by the automated reviewer labels Mar 28, 2026

kellyelton removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 28, 2026

kellyelton added the reviewing PR is currently being reviewed by the automated reviewer label Mar 28, 2026

kellyelton removed the reviewing PR is currently being reviewed by the automated reviewer label Mar 28, 2026

Conversation

kellyelton commented Mar 25, 2026

Summary

Changes

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 28, 2026

Uh oh!

kellyelton commented Mar 28, 2026

Uh oh!

kellyelton commented Mar 28, 2026

Uh oh!

kellyelton commented Mar 28, 2026

Uh oh!

kellyelton commented Mar 28, 2026

Uh oh!

kellyelton commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant